Re: Removing unneeded self joins

From: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
To: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Removing unneeded self joins
Date: 2023-07-05 14:28:59
Message-ID: bcf2f3c5-fbdc-f85b-af3e-ebec616160f6@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

During the significant code revision in v.41 I lost some replacement
operations. Here is the fix and extra tests to check this in the future.
Also, Tom added the JoinDomain structure five months ago, and I added
code to replace relids for that place too.
One more thing, I found out that we didn't replace SJs, defined by
baserestrictinfos if no one self-join clause have existed for the join.
Now, it is fixed, and the test has been added.
To understand changes readily, see the delta file in the attachment.

--
regards,
Andrey Lepikhov
Postgres Professional

Attachment Content-Type Size
v41-v42-delta.txt text/plain 6.5 KB
v42-0001-Remove-self-joins.patch text/plain 96.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2023-07-05 14:33:30 Re: Parallel CREATE INDEX for BRIN indexes
Previous Message Ashutosh Bapat 2023-07-05 14:24:36 Re: logicalrep_message_type throws an error