Re: pgsql: Refactor libpq state machine for negotiating encryption

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor libpq state machine for negotiating encryption
Date: 2024-04-24 12:57:15
Message-ID: bb3b94da-afc7-438d-8940-cb946e553d9d@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 08.04.24 03:25, Heikki Linnakangas wrote:
> Refactor libpq state machine for negotiating encryption
>
> This fixes the few corner cases noted in commit 705843d294, as shown
> by the changes in the test.

Either this or something nearby appears to have broken the error
reporting from psql or libpq when failing to get an SSL connection:

PG16:

psql 'sslmode=require host=localhost'
psql: error: connection to server at "localhost" (::1), port 65432
failed: server does not support SSL, but SSL was required

master:

psql 'sslmode=require host=localhost'
psql: error: connection to server at "localhost" (::1), port 65432 failed:

(sic, the output ends after the colon).

This commit removed that detail error message string from the code, but
I don't see any similar message that would take its place.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-04-24 14:19:12 pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.
Previous Message Andrew Dunstan 2024-04-24 12:32:22 pgsql: Add pg_logging_init() calls missing in commit ba3e6e2bca