| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-04 14:53:31 |
| Message-ID: | b98aa7cf-d826-acb9-8e5b-b681bf874f00@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 4/4/23 3:43 PM, Amit Kapila wrote:
> On Tue, Apr 4, 2023 at 6:05 PM Drouvot, Bertrand
>
> I think we might want to consider slot's effective_xmin instead of
> data.xmin as we use that to store xmin_horizon when we build the full
> snapshot.
>
Oh, I did not know about the 'effective_xmin' and was going to rely only on the catalog xmin.
Reading the comment in the ReplicationSlot struct about the 'effective_xmin' I do think it makes sense to use it
(instead of data.xmin).
Please find attached v59 doing so.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v59-0006-Doc-changes-describing-details-about-logical-dec.patch | text/plain | 2.2 KB |
| v59-0005-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 32.8 KB |
| v59-0004-Fixing-Walsender-corner-case-with-logical-decodi.patch | text/plain | 8.3 KB |
| v59-0003-Allow-logical-decoding-on-standby.patch | text/plain | 12.0 KB |
| v59-0002-Arrange-for-a-new-pg_stat_database_conflicts-and.patch | text/plain | 10.4 KB |
| v59-0001-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 28.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-04-04 14:54:23 | Re: doc: add missing "id" attributes to extension packaging page |
| Previous Message | Pavel Borisov | 2023-04-04 14:52:58 | Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound |