Re: [PATCH] Add CANONICAL option to xmlserialize

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Chapman Flack <chap(at)anastigmatix(dot)net>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add CANONICAL option to xmlserialize
Date: 2023-10-05 07:38:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Chap

On 04.10.23 23:05, Chapman Flack wrote:
> I hope I'm not butting in, but I too would be leery of any default
> behavior that's going to say thing1 and thing2 are the same thing
> but ignoring (name part of thing here). If that's the comparison
> I mean to make, and it's as easy as CANONICAL WITHOUT COMMENTS
> to say that's what I mean, I'd be happy to write that. It also means
> that the next person reading my code will know "oh, he means
> 'same' in *that* way", without having to think about it.

That's a very compelling argument. Thanks for that!

It is indeed clearer to only remove items from the result set if
explicitly said so.

v8 attached changes de default behaviour to WITH COMMENTS.



Attachment Content-Type Size
v8-0001-Add-CANONICAL-output-format-to-xmlserialize.patch text/x-patch 47.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-10-05 07:38:51 Re: Remove MSVC scripts from the tree
Previous Message David Rowley 2023-10-05 07:33:12 Re: [PATCH] Fix memory leak in memoize for numeric key