| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [19] CREATE SUBSCRIPTION ... SERVER |
| Date: | 2026-03-02 21:34:23 |
| Message-ID: | b881ea575dab426422e483ab7edfcd98b532cbef.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2026-02-26 at 11:12 -0800, Jeff Davis wrote:
> On Wed, 2026-02-04 at 13:53 +0900, Masahiko Sawada wrote:
> > I've reviewed the latest patch set. I understand the motivation
> > behind
> > this proposal and find it useful.
>
> Thank you, that's important feedback.
Attached v18:
* rebase
* Changed ForeignServerConnectionString() to use a local variable
rather than a static. It's not very performance-sensitive, so it's OK
to create a memory context for each invocation, which will be deleted.
I'm not aware of an actual problem in the previous code, but it seemed
a bit less safe.
I plan to commit the main patch (v18-0001) soon, after rechecking some
details (like the postgres_fdw upgrade). v18-0002 could use some review
first.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0001-CREATE-SUBSCRIPTION-.-SERVER.patch | text/x-patch | 128.1 KB |
| v18-0002-dblink-support-foreign-data-wrapper-CONNECTION-c.patch | text/x-patch | 9.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-03-02 21:37:01 | Re: Hash-based MCV matching for large IN-lists |
| Previous Message | Greg Burd | 2026-03-02 20:40:56 | Re: Areas for Solaris support modernization |