Re: ECPG: WHENEVER statement with DO CONTINUE action

From: vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ECPG: WHENEVER statement with DO CONTINUE action
Date: 2017-08-18 08:20:18
Message-ID: b82438fb-e085-f7d0-adc0-2583b6457400@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


On 2017/06/20 17:35, vinayak wrote:
> Hi Sawada-san,
>
> On 2017/06/20 17:22, Masahiko Sawada wrote:
>> On Tue, Jun 20, 2017 at 1:51 PM, vinayak
>> <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>
>>> On 2017/06/12 13:09, vinayak wrote:
>>>
>>> Hi,
>>>
>>> On 2017/06/10 12:23, Vinayak Pokale wrote:
>>>
>>> Thank you for your reply
>>>
>>> On Jun 9, 2017 5:39 PM, "Michael Meskes" <meskes(at)postgresql(dot)org> wrote:
>>>> Could you please add a "DO CONTINUE" case to one of the test cases? Or
>>>> add a new one? We would need a test case IMO.
>>>>
>>> Yes I will add test case and send updated patch.
>>>
>>> I have added new test case for DO CONTINUE.
>>> Please check the attached patch.
>>>
>>> I have added this in Sept. CF
>>> https://commitfest.postgresql.org/14/1173/
>>>
>> ------
>> In whenever_do_continue.pgc file, the following line seems not to be
>> processed successfully by ecpg but should we fix that?
>>
>> +
>> + exec sql whenever sqlerror continue;
>> +
>>
>> Also, you wrote the test case using "WHENEVER sqlerror DO CONTINUE"
>> action but that seems not to emit sqlerror, so "DO CONTINUE" is not
>> executed. I think the test case for DO CONTINUE should be a C code
>> that executes the "continue" clause.
> Thank you for testing the patch.
> I agreed with your comments. I will update the patch.
Please check the attached updated patch.

Regards,
Vinayak Pokale
NTT Open Source Software Center

Attachment Content-Type Size
WHENEVER-statement-DO-CONTINUE-support_v1.patch text/x-diff 17.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-08-18 08:21:47 Re: recovery_target_time = 'now' is not an error but still impractical setting
Previous Message Andrey Borodin 2017-08-18 08:11:40 Re: [PROPOSAL] Use SnapshotAny in get_actual_variable_range