| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: warn_unused_results |
| Date: | 2020-11-11 10:07:59 |
| Message-ID: | b49372e0-e951-32c5-03db-78a7fcbf0f1e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-11-10 04:34, Michael Paquier wrote:
>>> I am not sure
>>> about the addition of repalloc(), as it is quite obvious that one has
>>> to use its result. Lists are fine, these are proper to PG internals
>>> and beginners tend to be easily confused in the way to use them.
>> realloc() is listed in the GCC documentation as the reason this option
>> exists, and glibc tags its realloc() with this attribute, so doing the same
>> for repalloc() seems sensible.
> Good point.
committed
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2020-11-11 10:54:18 | Re: Clean up optional rules in grammar |
| Previous Message | Andrew Gierth | 2020-11-11 09:53:40 | Strange GiST logic leading to uninitialized memory access in pg_trgm gist code |