Re: Red-Black tree traversal tests

From: Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Red-Black tree traversal tests
Date: 2017-09-08 15:44:00
Message-ID: b3648015b3440a5dc1d9ffc1b32c1b93@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-09-08 15:23, Thomas Munro wrote:
> On Fri, Sep 8, 2017 at 9:03 PM, Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru>
> wrote:
>> Thank you very much for your review. In the attachment you can find v2
>> of
>> the patch.
>
> FYI this version crashes for me:
>
> test test_rbtree ... FAILED (test process exited with exit
> code 2)
>
> It's trying to call rb->combiner which is null.
>
Thank you for pointing on it. Here is a fixed version.

--
Victor Drobny
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
rbtree_test_3.patch text/x-diff 20.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2017-09-08 15:53:03 Re: pgsql: Fix assorted portability issues in new pgbench TAP tests.
Previous Message Peter Eisentraut 2017-09-08 15:36:46 Re: More flexible LDAP auth search filters?