| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Joel Jacobson <joel(at)compiler(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Missing free_var() at end of accum_sum_final()? |
| Date: | 2023-09-04 06:55:29 |
| Message-ID: | b294c65f-1494-11b7-d7af-966ced5de6b7@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05.03.23 09:53, Joel Jacobson wrote:
> On Fri, Mar 3, 2023, at 16:11, Dean Rasheed wrote:
>> Attachments:
>> * make-result-using-vars-buf-v2.patch
>
> One suggestion: maybe add a comment explaining why the allocated buffer
> which size is based on strlen(cp) for the decimal digit values,
> is guaranteed to be large enough also for the result's digit buffer?
>
> I.e. some kind of proof why
>
> (NUMERIC_HDRSZ + strlen(cp) + DEC_DIGITS * 2) >= ((ndigits + 1) * sizeof(NumericDigit)))
>
> holds true in general.
It looks like this thread has fizzled out, and no one is really working
on the various proposed patch variants. Unless someone indicates that
they are still seriously pursuing this, I will mark this patch as
"Returned with feedback".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-09-04 07:12:32 | Re: Unlogged relation copy is not fsync'd |
| Previous Message | Amit Kapila | 2023-09-04 06:49:35 | Re: pg_upgrade and logical replication |