Re: [BUG] pg_upgrade test fails from older versions.

Hello!

On 23.12.2022 05:42, Michael Paquier wrote:
> On Thu, Dec 22, 2022 at 09:59:18AM +0300, Anton A. Melnikov wrote:
>> 2) v2-0002-Additional-dumps-filtering.patch
>
> + # Replace specific privilegies with ALL
> + $dump_contents =~ s/^(GRANT\s|REVOKE\s)(\S*)\s/$1ALL /mgx;
> This should not be in 0002, I guess..

Made a separate patch for it: v3-0001-Fix-dumps-filtering.patch

On 26.12.2022 05:52, Michael Paquier wrote:
> On Fri, Dec 23, 2022 at 12:43:00PM +0300, Anton A. Melnikov wrote:
> I was looking at 0002 to add a callback to provide custom filtering
> rules.
>
> + my @ext_filter = split('\/', $_);
> Are you sure that enforcing a separation with a slash is a good idea?
> What if the filters include directory paths or characters that are
> escaped, for example?
>
> Rather than introducing a filter.regex, I would tend to just document
> that in the README with a small example. I have been considering a
> few alternatives while making this useful in most cases, still my mind
> alrways comes back to the simplest thing we to just read each line of
> the file, chomp it and apply the pattern to the log file..

Thanks for your attention!
Yes, indeed. It will be really simpler.
Made it in the v3-0002-Add-external-dumps-filtering.patch

With the best wishes,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company