| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: pg_regress: schedule multi-line test groups |
| Date: | 2026-11-20 00:37:57 |
| Message-ID: | av-WZWtADZWL5xvO@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2026 at 08:25:32AM +0000, Alexandre Felipe wrote:
> > + * Maximum supported number of concurrent tests
> > + */
> > +#define MAX_PARALLEL_TESTS 100
> >
> > This is now defined twice.
> >
>
> Ups, I think I removed now...
+test:
+ boolean
+ char
+ name
While reading through this patch, I am wondering if it would not be
better to support backslashes instead of an arbitrary amount of spaces
a-la-yaml for each group, like:
+test: \
+ boolean \
+ char \
+ name \
And that may actually make the patch simpler overall with less
hardcoded rules arount "test:". I can see that 0001 adds two more of
them, reducing the code readability. That would also work as a
backward-compatible grammar. Perhaps I'm too pedantic, so feel free
to overwrite me, of course.
0002 provides a cute metric, but I doubt that it is strictly
necessary. Performance matters for grouping, but that's not the only
reason why we have groups: we want some organization as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-11-20 00:41:40 | Re: Injection point: fix race condition between attach and cleanup |
| Previous Message | surya poondla | 2026-11-20 00:34:30 | Re: [BUG] Take a long time to reach consistent after pg_rewind |