Re: Bug in logical decoding with DDL and subtransactions

From: "alvherre(at)kurilemu(dot)de" <alvherre(at)kurilemu(dot)de>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: 'Bingshuai Li' <lucian1412(at)outlook(dot)com>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mark(dot)dilger(at)enterprisedb(dot)com" <mark(dot)dilger(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, "a(dot)kozhemyakin(at)postgrespro(dot)ru" <a(dot)kozhemyakin(at)postgrespro(dot)ru>
Subject: Re: Bug in logical decoding with DDL and subtransactions
Date: 2026-10-14 18:15:28
Message-ID: as_FwZjm4gZ6_cAz@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Oct-09, Hayato Kuroda (Fujitsu) wrote:

> Also, while thinking on it, I started to think whether we have to clean up
> Tuplecids even if the transactions will be skipped. In this case transactions are
> Not replied thus the issue won't happen, right?

Yeah, I think that's correct. I was wondering myself if the 2PC case is
correct -- we call ReorderBufferCleanupAbortedTupleCids() only when
two_phase is false. Do we call DecodeAbort() again for those? I am not
familiar with the 2PC support here. The comment for DecodeAbort() could
be better for sure.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-10-14 19:14:01 Re: Parallel autovacuum: honor reduced parallel workers after heap scan phase
Previous Message Haibo Yan 2026-10-14 18:12:57 Re: Perf: Specialize ExecIndexOnlyScan() like ExecSeqScan()