Re: [PATCH] pgbench: add multiconnect option

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, David Christensen <david(dot)christensen(at)crunchydata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgbench: add multiconnect option
Date: 2022-03-19 16:43:52
Message-ID: alpine.DEB.2.22.394.2203191725001.1545063@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi Sami,

> Pgbench is a simple benchmark tool by design, and I wonder if adding
> a multiconnect feature will cause pgbench to be used incorrectly.

Maybe, but I do not see how it would be worse that what pgbench already
allows.

> A real world use-case will be helpful for this thread.

Basically more versatile testing for non single host setups.

For instance, it would allow testing directly a multi-master setup, such
as bucardo, symmetricds or coackroachdb.

It would be a first step on the path to allow interesting features such
as:

- testing failover setup, on connection error a client could connect to
another host.

- testing a primary/standby setup, with write transactions sent to the
primary and read transactions sent to the standbyes.

Basically I have no doubt that it can be useful.

> For the current patch, Should the report also cover per-database
> statistics (tps/latency/etc.) ?

That could be a "per-connection" option. If there is a reasonable use case
I think that it would be an easy enough feature to implement.

Attached a rebased version.

--
Fabien.

Attachment Content-Type Size
pgbench-multi-connect-conninfo-3.patch text/x-diff 8.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2022-03-19 17:11:38 Re: Column Filtering in Logical Replication
Previous Message Dong Wook Lee 2022-03-19 16:18:26 Re: Add pg_freespacemap extension sql test