Re: pgbench logging broken by time logic changes

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, david(dot)christensen(at)crunchydata(dot)com
Subject: Re: pgbench logging broken by time logic changes
Date: 2021-07-10 09:36:13
Message-ID: alpine.DEB.2.22.394.2107101127400.775110@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello again,

>> I hoped we were done here but I realised that your check for 1-3 log
>> lines will not survive the harsh environment of the build farm.
>> Adding sleep(2) before the final doLog() confirms that. I had two
>> ideas:

>> So I think we should do 1 for now. Objections or better ideas?
> At least, we now that it is too much.

I misread your point. You think that it should fail, but it is not
tried yet. I'm rather optimistic that it should not fail, but I'm okay
with averting the risk anyway.

> What about moving the test as is in the TODO section with a comment, next to
> the other one, for now?

I stand by this solution which should allow to get some data from the
field, as v18 attached. If all is green then the TODO could be removed


Attachment Content-Type Size
pgbench-log-fix-18.patch text/x-diff 7.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2021-07-10 10:44:18 Re: Enhanced error message to include hint messages for redundant options error
Previous Message Erik Rijkers 2021-07-10 09:07:18 Re: SQL/JSON: JSON_TABLE