Re: pgbench logging broken by time logic changes

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, david(dot)christensen(at)crunchydata(dot)com
Subject: Re: pgbench logging broken by time logic changes
Date: 2021-06-23 20:01:28
Message-ID: alpine.DEB.2.22.394.2106232158120.1601973@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Ola Álvaro,

> ... or, actually, even better would be to use a TODO block, so that the
> test is run and reports its status, but if it happens not to succeed it
> will not cause the whole test to fail. That way you'll accumulate some
> evidence that may serve to improve the test in the future until it
> works fully:
> TODO: {
> local $TODO = "Ths test is unreliable";
> ok(1.5 < $delay && $delay < 2.5, "-T 2 run around 2 seconds");
> }

Thanks for the hint! Why not, having the ability to collect data is a good
thing, so attached v10 does that. If something go wrong, the TODO section
could be extended around all calls.


Attachment Content-Type Size
pgbench-log-fix-10.patch text/x-diff 9.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2021-06-23 21:46:10 Re: Emit namespace in post-copy output
Previous Message Ranier Vilela 2021-06-23 17:38:26 Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c)