Re: psql - add SHOW_ALL_RESULTS option

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: 2021-06-12 09:41:24
Message-ID: alpine.DEB.2.22.394.2106121130400.4105466@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Peter,

>> My overly naive trust in non regression test to catch any issues has been
>> largely proven wrong. Three key features do not have a single tests. Sigh.
>> I'll have some time to look at it over next week-end, but not before.
> I have reverted the patch and moved the commit fest entry to CF 2021-07.

Attached a v7 which fixes known issues.

I've tried to simplify the code and added a few comments. I've moved query
cancellation reset in one place in SendQuery. I've switched to an array of
buffers for notices, as suggested by Tom.

The patch includes basic AUTOCOMMIT and ON_ERROR_ROLLBACK tests, which did
not exist before, at all. I tried cancelling queries manually, but did not
develop a test for this, mostly because last time I submitted a TAP test
about psql to raise its coverage it was rejected.

As usual, what is not tested does not work…


Attachment Content-Type Size
psql-show-all-results-7.patch text/x-diff 48.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-06-12 10:47:54 Re: Question about StartLogicalReplication() error path
Previous Message Zhihong Yu 2021-06-12 08:35:59 Re: Add client connection check during the execution of the query