Re: fe-utils - share query cancellation code

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fe-utils - share query cancellation code
Date: 2019-11-01 17:41:52
Message-ID: alpine.DEB.2.21.1911011835260.27369@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>> I understand that you are unhappy about something, but where the issue is
>> fails me, the "wtf" 3 characters are not enough to point me in the right
>> direction. Feel free to elaborate a little bit more:-)
> I don't see why you move the "conditional.h" line out of its correct
> alphabetical position (where it is now), and then add "cancel.h" next to
> it also out of its correct alphabetical position.

Because "cancel.h" requires PGconn declaration, thus must appear after
"libpq-fe.h", and once I put it after that letting "conditional.h" above &
alone looked a little bit silly. I put cancel after conditional because it
was the new addition, which is somehow logical, although not alphabetical.

Now I can put cancel before conditional, sure.

Patch v3 attached does that.


Attachment Content-Type Size
fe-cancel-3.patch text/x-diff 22.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2019-11-01 17:51:26 Re: MarkBufferDirtyHint() and LSN update
Previous Message Andres Freund 2019-11-01 17:34:10 Re: On disable_cost