Re: fe-utils - share query cancellation code

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fe-utils - share query cancellation code
Date: 2019-11-01 09:19:04
Message-ID: alpine.DEB.2.21.1911010809130.27369@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


> I give a quick look and I think we can
> void
> psql_setup_cancel_handler(void)
> {
> setup_cancel_handler(psql_sigint_callback);
> }
> Because it does not matter for setup_cancel_handler what we passed
> because it is ignoring that in case of windows.

The "psql_sigint_callback" function is not defined under WIN32.

I've fixed a missing NULL argument in the section you pointed out, though.

I've used the shared infrastructure in pgbench.

I've noticed yet another instance of the cancelation stuff in
"src/bin/pg_dump/parallel.c", but it seems somehow different from the two
others, so I have not tried to used the shared version.


Attachment Content-Type Size
fe-cancel-2.patch text/x-diff 22.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-11-01 09:25:17 Re: 64 bit transaction id
Previous Message Ibrar Ahmed 2019-11-01 09:17:03 Re: The command tag of "ALTER MATERIALIZED VIEW RENAME COLUMN"