Re: psql - improve test coverage from 41% to 88%

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - improve test coverage from 41% to 88%
Date: 2019-09-12 08:45:06
Message-ID: alpine.DEB.2.21.1909121038490.19467@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>> Ok. Rebased version added, with some minor changes to improve readability
>> (comments, variables).
> Few comments: [...]
> Commented line can be removed
> Commented lines can be removed
> ??? can be changed to some suitable heading
> tab-complation to be changed to tab-completion
> Commented lines can be removed, some more are present below these lines also.

Thanks for this review.

The lines were really tests I did that had some issues because of the way
the Expect module works, and are not useful for inclusion in the code

Here is a v5.

Fabien Coelho - CRI, MINES ParisTech

Attachment Content-Type Size
psql-tap-5.patch text/x-diff 47.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Esteban Zimanyi 2019-09-12 09:22:13 Re: Specifying attribute slot for storing/reading statistics
Previous Message Kyotaro Horiguchi 2019-09-12 08:35:36 Re: standby recovery fails (tablespace related) (tentative patch and discussion)