psql FETCH_COUNT feature does not work with combined queries

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: psql FETCH_COUNT feature does not work with combined queries
Date: 2019-07-26 10:02:14
Message-ID: alpine.DEB.2.21.1907260837150.13195@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello devs,

As pointed out by Kyotaro Horiguchi in

FETCH_COUNT does not work with combined queries, and probably has never
worked since 2006.

What seems to happen is that ExecQueryUsingCursor is hardcoded to handle
one simple query. It simply inserts the cursor generation in front of the
query believed to be a select:

DECLARE ... <query>

For combined queries, say two selects, it results in:

DECLARE ... <first select>; <second select>

Then PQexec returns the result of the second one, and nothing is printed.

However, if the second query is not a select, eg: "select ... \; update
... ;", the result of the *first* query is shown.

How fun!

This is because PQexec returns the second result. The cursor declaration
expects a PGRES_COMMAND_OK before proceeding. With a select it gets
PGRES_TUPLES_OK so decides it is an error and silently skips to the end.
With the update it indeed obtains the expected PGRES_COMMAND_OK, not
really for the command it sent but who cares, and proceeds to show the
cursor results.

Basically, the whole logic is broken.

The minimum is to document that it does not work properly with combined
queries. Attached patch does that, so that the bug becomes a documented
bug, aka a feature:-)

Otherwise, probably psql lexer could detect, with some efforts, that it is
a combined query (detect embedded ; and check that they are not empty
queries), so that it could skip the feature if it is the case.

Another approach would be to try to detect if the returned result does not
correspond to the cursor one reliably. Maybe some result counting could be
added somewhere so that the number of results under PQexec is accessible
to the user, i.e. result struct would contain its own number. Hmmm.

A more complex approach would be to keep the position of embedded queries,
and to insert cursor declarations where needed, currently the last one if
it is a SELECT. However, for the previous ones the allocation and such
could be prohibitive as no cursor would be used. Not sure it is worth the
effort as the bug has not been detected for 13 years.


Attachment Content-Type Size
psql-fetch-count-doc-1.patch text/x-diff 540 bytes


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-07-26 10:28:45 Re: make libpq documentation navigable between functions
Previous Message Peter Eisentraut 2019-07-26 09:49:52 Re: make libpq documentation navigable between functions