Re: refactoring - share str2*int64 functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: refactoring - share str2*int64 functions
Date: 2019-07-13 15:22:05
Message-ID: alpine.DEB.2.21.1907131659350.22273@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Thomas,

> pg_stat_statements.c:1024:11: error: implicit declaration of function
> 'pg_strtouint64' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> rows = pg_strtouint64(completionTag + 5, NULL, 10);
> ^
> Apparently it needs to include common/string.h.

Yep, I gathered that as well, but did not act promptly on your help.
Thanks for it!

Here is the updated patch on which I checked "make check-world".


Attachment Content-Type Size
share-strtoX64-functions-3.patch text/x-diff 18.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-07-13 15:39:55 Re: [sqlsmith] Crash in mcv_get_match_bitmap
Previous Message Fabien COELHO 2019-07-13 15:19:41 Re: [PATCH] Implement uuid_version()