Re: pgbench - add option to show actual builtin script code

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fabien Coelho <postgresql(dot)org(at)coelho(dot)net>
Subject: Re: pgbench - add option to show actual builtin script code
Date: 2019-05-02 14:25:42
Message-ID: alpine.DEB.2.21.1905021623050.2241@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello,

> Patch looks good to me, and work fine on my machine. One minor
> observation is option 'list' mostly used to list the elements like
> "pgbench -b list" shows the available builtin scripts. Therefore we
> should use a word which seems to be more relevant like --show-script.

Thanks for the review.

Here is a version with "--show-script". I also thought about "--listing",
maybe.

> The new status of this patch is: Waiting on Author

--
Fabien.

Attachment Content-Type Size
pgbench-builtin-list-2.patch text/x-diff 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-05-02 14:28:30 Re: New vacuum option to do only freezing
Previous Message Robert Haas 2019-05-02 14:20:25 Re: New vacuum option to do only freezing