Re: pgbench - add minimal stats on initialization

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - add minimal stats on initialization
Date: 2019-04-10 17:39:00
Message-ID: alpine.DEB.2.21.1904101935100.19300@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello,

Thanks for the feedback.

> I have one minor observation that in case of initDropTables you log
> 'drop' and in case of initCreateTables you log 'create table'. We need
> to be consistent. The "drop tables" and "create tables" are the best
> fit here.

Ok.

Attached version does that, plus avoids re-assigning "first" on each loop,
plus checks that --no-vacuum indeed removes all vacuums in the TAP test.

--
Fabien.

Attachment Content-Type Size
pgbench-init-stats-3.patch text/x-diff 2.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2019-04-10 17:41:17 Re: Status of the table access method work
Previous Message Andres Freund 2019-04-10 17:32:16 Re: Status of the table access method work