Re: pgbench - add pseudo-random permutation function

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Hironobu SUZUKI <hironobu(at)interdb(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - add pseudo-random permutation function
Date: 2018-10-24 20:43:02
Message-ID: alpine.DEB.2.21.1810242235170.26778@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Alvaro,

> Can you please pgindent this?

Hmmm. After some investigation, I installed some "pg_bsd_indent" and ran
the "pgindent" script, which reindented far more than the patch... So I
picked up the patch-related changes and integrated them manually, although
not comment changes which break the logic of the algorithm descriptions. I
have not found how to tell pgindent to let comments indentation alone.

Here is the result for the code, and for part of comments.


Attachment Content-Type Size
pgbench-prp-func-11.patch text/x-diff 18.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-10-24 20:49:57 Re: JSON validation behavior
Previous Message Robert Haas 2018-10-24 20:01:29 Re: Side effect of CVE-2017-7484 fix?