|From:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|To:||Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>|
|Subject:||Re: pgbench exit code|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
>> The abort is by a client, but the code seems to only check the first
>> client of a thread. ISTM that if the second or later client abort it may
>> not be detected? Probably an intermediate aggregation at the thread level
>> is needed, or maybe a global variable, or as errors are counted somewhere,
>> it may be enough just to check that the count is non zero?
With an aggregation. Fine with me.
>> The patch removes a check that there was an output and that no
>> transactions where processed. ISTM it should be kept. If a different exit
>> status is chosen on abort, that would allow to keep it easily.
>> Probably there should be some documentation changes as well?
Patch applies cleanly, compiles, global & local "make check" are ok.
Doc build is okay.
I noticed "for (int i"… pgbench is welcome to C99:-)
No further remarks. I turned the patch as ready on the CF app.
Attached a file I used for some manual tests.
|Next Message||Tom Lane||2018-10-12 19:55:07||Re: Make Windows print float exponents like everybody else?|
|Previous Message||Tom Lane||2018-10-12 18:50:46||Re: AllocSetContextCreate changes breake extensions|