Re: pgbench - add \if support

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - add \if support
Date: 2018-03-21 18:10:23
Message-ID: alpine.DEB.2.20.1803211841500.1860@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello Teodor,

> Patch seems usefull and commitable except comments in conditional.[ch]. I'd
> like to top/header comment in each file more detailed and descriptive. As for
> now it mentions only psql usage without explaining how it is basic or common.

Indeed, it was not updated.

I've fixed the file names and added a simple description at the beginning
of the header file, and a one liner in the code file.

Do you think that more is needed?

The patch also needed a rebase after the hash function addition.

--
Fabien.

Attachment Content-Type Size
pgbench-if-7.patch text/plain 39.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2018-03-21 18:35:54 Re: [HACKERS] pg_upgrade to clusters with a different WAL segment size
Previous Message Peter Eisentraut 2018-03-21 17:57:01 Re: [HACKERS] pg_upgrade to clusters with a different WAL segment size