|From:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|To:||Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>|
|Cc:||PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: psql - add special variable to reflect the last query status|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
>> I agree that the existing "SetVariableBool" function is a misnommer, it
>> should be "SetVariableOn" given what it does, and it is not what we
> switching default setting from ON to TRUE requires wider discussion -
> in this moment I like to have special function "SetVariableON".
I'm fine with this, but this make it a change totally unrelated to this
patch as it would not use the function... Moreover, this function would
not use an hypothetical "set var bool" function because of the debatable
on/off vs true/false change.
Also, a "set var bool" function would be called only twice, which is not
very beneficial for a oneliner, so I left it out.
>> I agree that there is some common structure, but ISTM that the
>> AcceptResult function is called in a variety of situation where variables
>> are not to be set (eg "internal" queries, not user provided queries), so I
>> thought it best to keep the two apart.
> I understand, but It is not nice, really - maybe only switch can be moved
> to some inlining function like IsSuccess() - more .. with this function,
> the SetResultVariables function will be more cleaner
Indeed. Attached v5 does that.
|Next Message||Pavel Stehule||2017-06-28 07:48:35||Re: psql - add special variable to reflect the last query status|
|Previous Message||Thomas Munro||2017-06-28 07:07:50||Re: Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().|