Re: pgbench - allow backslash continuations in \set expressions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - allow backslash continuations in \set expressions
Date: 2016-12-03 08:22:39
Message-ID: alpine.DEB.2.20.1612030916210.4497@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> FWIW, I looked a bit further and concluded that probably psqlscan.l
> doesn't need to be modified; so likely you could do this across all of
> pgbench's commands without touching psql. That might be an acceptable
> compromise for now, though I still think that as soon as we have this
> for pgbench, users will start wanting it in psql.

The attached patch adds backslash-return (well newline really)
continuations to all pgbench backslash-commands.

The attached test uses continuations on all such commands (sleep set
setshell and shell).

I think that adding continuations to psql should be a distinct patch.

--
Fabien.

Attachment Content-Type Size
pgbench-continuation-2.patch text/x-diff 1.6 KB
cont.sql application/x-sql 231 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Seltenreich 2016-12-03 10:14:25 Re: [sqlsmith] Failed assertion in _hash_splitbucket_guts
Previous Message Pavel Stehule 2016-12-03 07:28:50 Re: patch: function xmltable