Re: pgbench stats per script & other stuff

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench stats per script & other stuff
Date: 2016-03-29 19:18:21
Message-ID: alpine.DEB.2.10.1603292053550.5677@sto
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello,

>> In doing this, I noticed that the latency output is wrong if you use -T
>> instead of -t; it always says the latency is zero because "duration" is
>> zero. I suppose it should be like in the attached instead.

Indeed, I clearly overlooked option -t (transactions) which I never use.

> Patch actually attached here.

Tested. There is a small issue because the \n is missing.

Here is another version which just replaces duration by time_include,
as they should be pretty close, and fixes the style so that it is the same
whether the detailed stats are collected or not, as you pointed out.

>> At the same time, it says "latency average: XYZ" instead of "latency
>> average = XYZ" as in printSimpleStats, which doesn't look terribly
>> important. But the line appears in the SGML docs.

Indeed. The documentation is manually edited when submitting changes so as
to minimize diffs, but then it does not correspond anymore to any actual
output, so it is easy to do it wrong.

--
Fabien.

Attachment Content-Type Size
pgbench-latency-2.patch text/x-diff 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-03-29 19:22:30 Re: pgbench stats per script & other stuff
Previous Message Paul Ramsey 2016-03-29 19:06:05 Re: Parallel Queries and PostGIS