| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench small bug fix |
| Date: | 2016-03-09 09:12:27 |
| Message-ID: | alpine.DEB.2.10.1603091005231.25393@sto |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, Jan 27, 2016 at 2:31 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>> - when a duration (-T) is specified, ensure that pgbench ends at that
>> time (i.e. do not wait for a transaction beyond the end of the run).
>
> Every other place where doCustom() returns false is implemented as
> return clientDone(...). I think this should probably do the same.
Why not. clientDone() second arguments is totally ignored, I put true
because it looks better.
> I also think that we should probably store the end time someplace
> instead of recomputing it in multiple places (this patch adds two such
> places).
Why not.
Attached is a v4.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-duration-under-rate-4.patch | text/x-diff | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2016-03-09 09:13:09 | Re: WIP: Access method extendability |
| Previous Message | Emre Hasegeli | 2016-03-09 09:00:17 | Re: SP-GiST support for inet datatypes |