Re: extend pgbench expressions with functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extend pgbench expressions with functions
Date: 2016-02-17 08:22:36
Message-ID: alpine.DEB.2.10.1602170916030.2706@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Michaël,

> \set aid 1 + 1
> pgbench -f addition.sql -t 50000000
>
> I have the following:
> HEAD: 3.5~3.7M TPS
> list method: 3.6~3.7M TPS
> array method: 3.4~3.5M TPS
> So all approaches have a comparable performance.

Yep, the execution trace is pretty similar in all cases, maybe with a
little more work for the array method, although I'm surprise that the
difference is discernable.

> Btw, patch 2 is returning a warning for me:
> It is trying to compare a 32b integer with an int64 value, evalFunc
> needed an int64.

Indeed. My gcc 4.8.4 with --Wall does not show the warning, too bad.

Attached is the fixed patch for the array method.

--
Fabien

Attachment Content-Type Size
pgbench-funcs-32-a-2.patch text/x-diff 18.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2016-02-17 08:24:26 Re: commitfest application doesn't see new patch
Previous Message Rushabh Lathia 2016-02-17 08:01:45 Should PostgresFDW ImportForeignSchema should import the remote table default expression?