Re: extend pgbench expressions with functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extend pgbench expressions with functions
Date: 2016-02-13 15:37:00
Message-ID: alpine.DEB.2.10.1602131616210.3721@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> But variables can still only be integers.

Version 28 attached has double variables, although typing is based on
guessing because it is just a string.

Any comment?

> [...] two separate enhancements in here. One of them is to support a
> new data type (doubles) and the other is to support functions.

The two features are highly intermix, so it can only be dependent patches,
first to add a function infrastructure and probably some support for
doubles altough it would not be used, then to add doubles & their
functions.

A real pain is the documentation, because it means writing a documentation
with only integer functions, then overwriting it with doubles. This is
dumb work, really, for the sake of "a cleaner git history", the beauty of
it no one will ever contemplate...

--
Fabien.

Attachment Content-Type Size
pgbench-funcs-28.patch text/x-diff 41.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christian Ullrich 2016-02-13 15:45:33 Re: Crash with old Windows on new CPU
Previous Message Andres Freund 2016-02-13 15:28:54 Re: pg_basebackup vs WAL fetching