|From:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|To:||Heikki Linnakangas <hlinnaka(at)iki(dot)fi>|
|Cc:||Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, mail(at)bwe(dot)im, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org>|
|Subject:||Re: BUG #12379: pgbench should hint to pgbench -i|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
>>>> Here's a v7 patch which display the hint only if SQLSTATE is
>>>> ERRCODE_UNDEFINED_TABLE and use the message Tom suggested, as there
>>>> wasn't any better suggestion or strong objection with it in the other
>>> I'm wondering why you added the define. Isn't-there some convenient
>>> include to get errcode definitions?
>> IIRC correctly, you have to include postgres.h for that. I supposed it
>> was better to define it than adding such an include, since it shouldn't
>> change and it's already done like this in vacuumdb.c.
> Ok, committed.
Thanks. Note that the author of the final version of the patch is mostly
Julien, who implemented Tom's suggested improvement, rather than myself.
|Next Message||Peter Geoghegan||2015-08-24 17:54:31||Re: BUG #13584: Upsert. The sequence value is increased.|
|Previous Message||av.kostromin||2015-08-22 18:25:10||BUG #13584: Upsert. The sequence value is increased.|