Re: add modulo (%) operator to pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add modulo (%) operator to pgbench
Date: 2015-01-05 09:38:00
Message-ID: alpine.DEB.2.10.1501051036310.23383@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> I'm also just looking at you ERROR() macro, it seems that core code is
> quite careful not to use __VA_ARGS__ on compilers where HAVE__VA_ARGS is
> not defined. I'd say this needs to be fixed too. Have a look at the trick
> used in elog.h for when HAVE__VA_ARGS is not defined.

Here is a v5 with the vararg macro expanded.

--
Fabien.

Attachment Content-Type Size
pgbench-expr-5.patch text/x-diff 22.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-01-05 09:49:06 Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments
Previous Message Heikki Linnakangas 2015-01-05 09:34:54 Re: Redesigning checkpoint_segments