|From:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|To:||Robert Haas <robertmhaas(at)gmail(dot)com>|
|Cc:||PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: add modulo (%) operator to pgbench|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Here is a review & updated version of the patch.
Patch applies and compiles without problem on current head,
and worked for the various tests I made with custom scripts.
This patch is a good thing, and I recommand warmly its inclusion. It
extends greatly pgbench custom capabilities by allowing arbitrary integer
expressions, and will allow to add other functions (I'll send abs() & a
hash(), and possibly others).
I'm not sure about what Makefile changes could be necessary for
various environments, it looks ok to me as it is.
I have included the following additional changes in v2:
(1) small update to pgbench documentation. English proof reading is welcome.
(2) improve error reporting to display the file and line from where an error
is raised, and also the column on syntax errors (yyline is always 1...).
The prior status was that there were no way to get this information, which
was quite annoying. It could probably be improved further.
(3) spacing fixed in a few places.
If Robert is ok with these changes, I think it could be applied.
|Next Message||Tomas Vondra||2014-12-31 12:49:20||Re: Initdb-cs_CZ.WIN-1250 buildfarm failures|
|Previous Message||Heikki Linnakangas||2014-12-31 11:18:18||Re: Redesigning checkpoint_segments|