Re: add modulo (%) operator to pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add modulo (%) operator to pgbench
Date: 2014-08-06 14:38:44
Message-ID: alpine.DEB.2.10.1408061633200.28413@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> Three different modulo operators seems like a lot for a language that
> doesn't even have a real expression syntax, but I'll yield to whatever
> the consensus is on this one.

Here is a third simpler patch which only implements the Knuth's modulo,
where the remainder has the same sign as the divisor.

I would prefer this version 3 (one simple modulo based on Knuth
definition) or if there is a problem version 2 (all 3 modulos). Version 1
which provides a modulo compatible with C & SQL is really useless to me.


Attachment Content-Type Size
pgbench-modulo-3.patch text/x-diff 1.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-08-06 15:15:01 Re: Scaling shared buffer eviction
Previous Message Fabien COELHO 2014-08-06 14:12:45 Re: Enhancing pgbench parameter checking