Skip site navigation (1) Skip section navigation (2)

Re: commit and rollback don't throw exceptions when they should

From: Kris Jurka <books(at)ejurka(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: taktos <taktos(at)gmail(dot)com>, Oliver Jowett <oliver(at)opencloud(dot)com>, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: commit and rollback don't throw exceptions when they should
Date: 2009-11-18 11:21:38
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-jdbc

On Wed, 4 Nov 2009, Kevin Grittner wrote:

> Having received no feedback on the preliminary patch I previously
> posted, I'll suggest this (fairly minimal) patch.  I didn't attempt to
> deal with the distributed transaction issue, since it seemed pretty
> messy and I wasn't sure the fix was worth the mess it would make.  As
> far as I can see, it should fix the OP's problem, although it would be
> nice to get a confirmation of that.

I've commited a modified version of this patch to HEAD only, because 
changing this behavior could break peoples applications.

I extended the check for the connection already being closed to the other 
connection methods.  There's no reason commit/rollback are special here.
I also needed to fix a regression testcase which was violating this rule.

Kris Jurka

In response to


pgsql-jdbc by date

Next:From: Kris JurkaDate: 2009-11-18 14:29:50
Subject: Re: BUG #5177: Concurrency problem in AbstractJdbc23PooledConnection
Previous:From: Maciek SakrejdaDate: 2009-11-17 17:40:34
Subject: COPY and turning off autocommit

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group