| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Li Japin <japinli(at)hotmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, kuroda(dot)hayato(at)fujitsu(dot)com |
| Subject: | Re: About to add WAL write/fsync statistics to pg_stat_wal view |
| Date: | 2021-01-25 07:51:31 |
| Message-ID: | afeef2fecff653f2e29d1dc5056c08a3@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, thanks for the reviews.
I updated the attached patch.
The summary of the changes is following.
1. fix document
I followed another view's comments.
2. refactor issue_xlog_fsync()
I removed "sync_called" variables, narrowed the "duration" scope and
change the switch statement to if statement.
3. make wal-receiver report WAL statistics
I add the code to collect the statistics for a written operation
in XLogWalRcvWrite() and to report stats in WalReceiverMain().
Since WalReceiverMain() can loop fast, to avoid loading stats collector,
I add "force" argument to the pgstat_send_wal function. If "force" is
false, it can skip reporting until at least 500 msec since it last
reported. WalReceiverMain() almost calls pgstat_send_wal() with "force"
as false.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v5_v6.diff | text/x-diff | 13.1 KB |
| v6-0001-Add-statistics-related-to-write-sync-wal-records.patch | text/x-diff | 19.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2021-01-25 07:51:32 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Fujii Masao | 2021-01-25 07:50:39 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |