| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: select_common_typmod |
| Date: | 2020-10-27 17:12:05 |
| Message-ID: | adf469d0-cbe2-1890-12c1-d5268d7b53ac@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-10-26 10:05, Heikki Linnakangas wrote:
>> There might have been a tiny bug in transformValuesClause() because
>> while consolidating the typmods it does not take into account whether
>> the types are actually the same (as more correctly done in
>> transformSetOperationTree() and buildMergedJoinVar()).
>
> Hmm, it seems so, but I could not come up with a test case to reach that
> codepath. I think you'd need to create two types in the same
> typcategory, but with different and incompatible typmod formats.
Yeah, something like that.
> The patch also adds typmod resolution for hypothetical ordered-set
> aggregate arguments. I couldn't come up with a test case that would
> tickle that codepath either, but it seems like a sensible change. You
> might want to mention it in the commit message though.
OK, committed with that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2020-10-27 17:23:26 | Re: MultiXact\SLRU buffers configuration |
| Previous Message | Alexander Korotkov | 2020-10-27 17:02:20 | Re: MultiXact\SLRU buffers configuration |