| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | sawada(dot)mshk(at)gmail(dot)com, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve tab completion for COPY |
| Date: | 2025-06-10 02:15:09 |
| Message-ID: | ac23e824d1d602f113a89c91ee56fb23@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-06-03 17:58, Yugo Nagata wrote:
> Thank you for updating the patch.
> It looks good and I confirmed that this works as expected.
Thanks for your review!
BTW this is a small patch, but it does two things:
(1) adds tab completion support for the REJECT_LIMIT option, which was
introduced in v18
(2) splits the tab completion logic between COPY FROM and COPY TO to
reflect their different options.
While maybe (2) should be postponed to v19 or later, I think it would be
better to include (1) in v18.
So I’ve split them into separate patches accordingly.
--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Improve-tab-completion-for-COPY-options.patch | text/x-diff | 3.2 KB |
| v3-0001-Add-tab-completion-for-COPY-REJECT_LIMIT-option.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-06-10 02:58:13 | Re: Cleanup gcc trick with varattrib_1b_e in VARATT_EXTERNAL_GET_POINTER() |
| Previous Message | Fabrízio de Royes Mello | 2025-06-10 01:54:43 | Re: [PATCH] Refactor: Extract XLogRecord info |