Re: [PATCH] Provide support for trailing commas

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Provide support for trailing commas
Date: 2026-02-17 08:30:02
Message-ID: ab27a660-72b4-41b6-9279-2f007e065fed@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03.02.26 18:28, Greg Sabino Mullane wrote:
> Having reread this thread, I'm not sure where we are at the moment. I'm
> happy to support a subset of things for the first run, and I think that
> will cover 99% of the use cases that people tend to complain about. So a
> small hit for consistency, but an added bonus of a little protection
> should the committee do something crazy.

I think there is consensus for allowing a trailing comma in the SELECT
list. This would be the target_list production in gram.y.

Looking into your patch, it looks pretty much like how I would have
implemented it, so if you could cut down your patch to just this
production, and add a small amount of documentation and tests, then I
think we could move forward with it.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavlo Golub 2026-02-17 08:30:26 Re: [PATCH] Add last_executed timestamp to pg_stat_statements
Previous Message Andreas Karlsson 2026-02-17 08:20:44 Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier