| From: | Ken Kato <katouknl(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Add min() and max() aggregate functions for xid8 |
| Date: | 2022-02-05 01:46:05 |
| Message-ID: | ab08311e1d07c584ac8ac5f59ad33730@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> + PG_RETURN_FULLTRANSACTIONID((U64FromFullTransactionId(fxid1) >
> U64FromFullTransactionId(fxid2)) ? fxid1 : fxid2);
>
> Shouldn't we use FullTransactionIdFollows() to compare those two fxid
> values here, instead?
>
> + PG_RETURN_FULLTRANSACTIONID((U64FromFullTransactionId(fxid1) <
> U64FromFullTransactionId(fxid2)) ? fxid1 : fxid2);
>
> Shouldn't we use FullTransactionIdPrecedes() to compare those two fxid
> values here, instead?
>
> Could you add the regression tests for those min() and max() functions
> for xid8?
Thank you for the comments.
I sent my old version of patch by mistake.
This is the updated one.
Best wishes
--
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| min_max_aggregates_for_xid8_v2.patch | text/x-diff | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-02-05 01:46:22 | Re: Windows now has fdatasync() |
| Previous Message | Amit Kapila | 2022-02-05 00:40:31 | Re: [BUG]Update Toast data failure in logical replication |