Re: Remove distprep

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove distprep
Date: 2023-07-14 08:56:26
Message-ID: aac9b420-03fb-f8fd-7c9e-672e01a38397@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14.07.23 09:54, Peter Eisentraut wrote:
>>> diff --git a/src/tools/pginclude/cpluspluscheck
>>> b/src/tools/pginclude/cpluspluscheck
>>> index 4e09c4686b..287395887c 100755
>>> --- a/src/tools/pginclude/cpluspluscheck
>>> +++ b/src/tools/pginclude/cpluspluscheck
>>> @@ -134,6 +134,9 @@ do
>>>       test "$f" = src/interfaces/ecpg/preproc/preproc.h && continue
>>>       test "$f" = src/test/isolation/specparse.h && continue
>>>
>>> +    # FIXME
>>> +    test "$f" = src/backend/utils/adt/jsonpath_internal.h && continue
>>> +
>>>       # ppport.h is not under our control, so we can't make it
>>> standalone.
>>>       test "$f" = src/pl/plperl/ppport.h && continue
>>
>> Hm, what's that about?
>
> Don't remember ... ;-)  I removed this.

Ah, there was a reason. The headerscheck and cpluspluscheck targets
need jsonpath_gram.h to be built first. Which previously happened
indirectly somehow? I have fixed this in the new patch version. I also
fixed the issue that Álvaro reported nearby.

Attachment Content-Type Size
v3-0001-Remove-distprep.patch text/plain 69.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martin Butter 2023-07-14 09:06:33 Re: 16beta2 SQL parser: different defaults on absent_on_null
Previous Message Dean Rasheed 2023-07-14 08:55:28 Re: MERGE ... RETURNING