Re: Defects with invalid stats data for expressions in extended stats

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Defects with invalid stats data for expressions in extended stats
Date: 2026-02-27 04:25:24
Message-ID: aaEctAQb8yDhqwaE@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 26, 2026 at 10:52:48PM -0500, Corey Huinker wrote:
> Patch applies for me, but there seems to be some user-specific stuff in the
> test, which causes it to fail:

Yep. I've noticed that in the CI a few minutes ago. I have switched
the tests to use a query where the owner does not show up, leading to
the same coverage without the user-dependency blip. I have checked
that this version cools down the CI.

> A nitpick about the test - it uses a plpgsql function when we've been
> moving such trivial functions to SQL standard function bodies for a while
> now, and they were introduced back in v14 so there's no backporting
> concern.

No, that's on purpose. Using a SQL function with a body would not
trigger the problem with the stats loaded at the end of the SQL test
as we would skip the fatal call of statext_expressions_load(). Based
on your confusion, I guess that a note to document that is in order,
at least, so as nobody comes with the idea of changing the definition
of this function..
--
Michael

Attachment Content-Type Size
v2-0001-Fix-two-defects-with-extended-statistics-for-expr.patch text/plain 3.5 KB
v2-0002-test_custom_types-Test-module-for-custom-data-typ.patch text/plain 23.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2026-02-27 04:28:02 Re: index prefetching
Previous Message Andres Freund 2026-02-27 04:18:03 Re: index prefetching