| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrey Klychkov <aaklychkov(at)mail(dot)ru> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Victor Yegorov <vyegorov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Alter index rename concurrently to |
| Date: | 2018-10-05 10:03:54 |
| Message-ID: | aa4b16af-5cca-ded6-f5fa-1a0dadcf5906@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/10/2018 13:51, Andrey Klychkov wrote:
> 1. Patch was applied without any errors except a part related to
> documentation:
> error: patch failed: doc/src/sgml/ref/alter_index.sgml:50
> error: doc/src/sgml/ref/alter_index.sgml: patch does not apply
Attached is an updated patch.
> 2. The code has been compiled successfully, configured by:
> # ./configure CFLAGS="-O0" --enable-debug --enable-cassert
> --enable-depend --without-zlib
Not sure why you use -O0 here. It's not a good idea for development,
because it might miss interesting warnings.
> 7. Code style:
> +RenameRelationInternal(Oid myrelid, const char *newrelname, bool
> is_internal, bool is_index)
> This line is longer than 80 chars.
pgindent leaves this line alone.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Lower-lock-level-for-renaming-indexes.patch | text/plain | 10.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2018-10-05 10:15:41 | Re: Problems with plan estimates in postgres_fdw |
| Previous Message | Etsuro Fujita | 2018-10-05 09:18:05 | Re: Problem while updating a foreign table pointing to a partitioned table on foreign server |