add assertion for palloc in signal handlers

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: add assertion for palloc in signal handlers
Date: 2026-02-17 22:24:58
Message-ID: aZTqurNQG-cDzJcL@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(new thread)

On Tue, Feb 17, 2026 at 03:30:57PM -0600, Nathan Bossart wrote:
> On Tue, Feb 17, 2026 at 11:18:00PM +0200, Heikki Linnakangas wrote:
>> On 14/02/2026 23:56, Andres Freund wrote:
>>> We really need some instrumentation that fails if we do allocations in signal
>>> handlers etc.
>>
>> Yeah, that would be nice..
>
> In theory we could pretty easily add assertions for that, given the
> wrapper_handler business added a couple of years ago. I'll put together a
> patch...

As promised... Fortunately, check-world didn't uncover any existing
issues. I was able to manually verify the assertion by switching a
background worker to use bgworker_die() and sending it SIGTERM. Probably
could use some additional commentary, which I'll add if the idea seems
reasonable to you.

--
nathan

Attachment Content-Type Size
v1-0001-Add-an-assertion-that-you-don-t-palloc-in-a-signa.patch text/plain 3.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-02-17 22:29:53 Re: Speed up COPY FROM text/CSV parsing using SIMD
Previous Message Tom Lane 2026-02-17 21:59:46 Re: generating function default settings from pg_proc.dat