| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Make use of unvolatize() in vac_truncate_clog() |
| Date: | 2026-02-24 18:16:10 |
| Message-ID: | aZ3q6omjSsQ6NoRV@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Feb 24, 2026 at 11:19:50AM -0600, Nathan Bossart wrote:
> On Tue, Feb 24, 2026 at 05:08:09PM +0000, Bertrand Drouvot wrote:
> > This patch makes use of unvolatize() in vac_truncate_clog().
> >
> > Note that it does not remove the warning but moves it to c.h (where unvolatize()
> > is defined) but that's consistent with what 481018f2804 did too.
>
> Why is this preferable to marking the function parameter as volatile
I think that that would sound misleading for the other callers that don't really
need the volatile qualification.
> or removing the volatile qualifier from the variable?
That looks mandatory according to 2d2e40e3bef.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2026-02-24 18:21:06 | [BUG?] estimate_hash_bucket_stats uses wrong ndistinct for avgfreq |
| Previous Message | Peter Geoghegan | 2026-02-24 18:13:25 | Re: index prefetching |