Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nikhil Kumar Veldanda <veldanda(dot)nikhilkumar17(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Burd, Greg" <greg(at)burd(dot)me>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Date: 2026-01-07 08:02:02
Message-ID: aV4S-s4bYIuIAW_E@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 07, 2026 at 01:43:26PM +0900, Michael Paquier wrote:
> While the final commit has sticked with oid8 for the data type and
> Oid8 for the C type, we still have a couple of months to tweak the
> names if necessary. I would keep these as they are, but if there are
> more voices for a Oid64, feel free of course. What's on HEAD now
> works fine enough for me.

I am still looking at a different approach that does not use the
redirection. For now, please find a rebased version of the patch,
which is the rest minus the oid8 support now committed and some
conflicts resolved, in case someone has any comments.
--
Michael

Attachment Content-Type Size
v10-0001-Refactor-some-TOAST-value-ID-code-to-use-Oid8-in.patch text/x-diff 15.4 KB
v10-0002-Minimize-footprint-of-TOAST_MAX_CHUNK_SIZE-in-he.patch text/x-diff 4.6 KB
v10-0003-Renames-around-varatt_external-varatt_external_o.patch text/x-diff 20.3 KB
v10-0004-Refactor-external-TOAST-pointer-code-for-better-.patch text/x-diff 46.3 KB
v10-0005-Move-static-inline-routines-of-varatt_external_o.patch text/x-diff 4.7 KB
v10-0006-Split-VARATT_EXTERNAL_GET_POINTER-for-indirect-a.patch text/x-diff 5.9 KB
v10-0007-Switch-pg_column_toast_chunk_id-return-value-fro.patch text/x-diff 3.6 KB
v10-0008-Add-catcache-support-for-OID8OID.patch text/x-diff 1.3 KB
v10-0009-Add-support-for-TOAST-chunk_id-type-in-binary-up.patch text/x-diff 9.3 KB
v10-0010-Enlarge-OID-generation-to-8-bytes.patch text/x-diff 14.5 KB
v10-0011-Add-relation-option-toast_value_type.patch text/x-diff 6.5 KB
v10-0012-Add-support-for-oid8-TOAST-values.patch text/x-diff 16.9 KB
v10-0013-Add-tests-for-TOAST-relations-with-bigint-as-val.patch text/x-diff 21.5 KB
v10-0014-Add-new-vartag_external-for-8-byte-TOAST-values.patch text/x-diff 14.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2026-01-07 08:06:23 Re: Implement waiting for wal lsn replay: reloaded
Previous Message Richard Guo 2026-01-07 07:31:27 Re: Fwd: pg18 bug? SELECT query doesn't work