Re: Remove unused struct fields

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Remove unused struct fields
Date: 2025-11-26 15:01:07
Message-ID: aScWM1lnwb9gsXtG@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 26, 2025 at 02:54:48PM +0000, Bertrand Drouvot wrote:
> Here are a few fields that are not used.

- const char *username; /* username from startup packet */
+ scram_state_enum state; /* username from startup packet */

- BlockNumber write_page; /* The next page to write to. */
+ BufFile *write_file; /* The current file to write to. */ /* The next page to write to. */

Something weird happened with the comments for these two. Otherwise, this
seems reasonable to me.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-11-26 15:02:31 Re: Additional info for CREATE ROLE with REPLICATION
Previous Message Bertrand Drouvot 2025-11-26 14:54:48 Remove unused struct fields