From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Remove make_temptable_name_n() |
Date: | 2025-10-10 15:46:29 |
Message-ID: | aOkqVUninoLnpOpD@nathan |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 10, 2025 at 06:22:46PM +0300, Aleksander Alekseev wrote:
> The proposed patch removes make_temptable_name_n() in matview.c. This
> function is used only once and can be replaced with psprintf().
This dates back to commit cc1965a, and I see some discussion about this
function in the corresponding thread [0]. One thing I don't like about
the patch is that we lose the comment about relying on the name to never be
double-quoted. IMHO that's worth retaining in some form.
[0] https://postgr.es/m/CAP7Qgm%3Djb3xkzQXfGtX9STx8fzd8EDDQ-oJ8ekcyeOud%2ByLCoA%40mail.gmail.com
--
nathan
From | Date | Subject | |
---|---|---|---|
Next Message | Bertrand Drouvot | 2025-10-10 15:52:58 | Re: Preserve index stats during ALTER TABLE ... TYPE ... |
Previous Message | Aleksander Alekseev | 2025-10-10 15:22:46 | [PATCH] Remove make_temptable_name_n() |